Skip to content

[Console] Allow ESQL suggestions in _query/async request #241424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Console] Allow ESQL suggestions in _query/async request #241424

wants to merge 1 commit into from
+3 −1

Conversation

@ElenaStoeva
Copy link
Contributor

Follow-up to #240264

Summary

This PR fixes a small regression introduced by #240264, where ESQL suggestions are no longer displayed for _query/async endpoints and they should be.

With this change, ESQL suggesstions should be displayed for the following endpoints:

_query
/_query
_query?...
/_query?...
_query/async
/_query/async
_query/async?...
/_query/async?...

@ElenaStoeva ElenaStoeva requested a review from a team October 31, 2025 09:51
@ElenaStoeva ElenaStoeva self-assigned this Oct 31, 2025
@ElenaStoeva ElenaStoeva requested a review from a team as a code owner October 31, 2025 09:51
@ElenaStoeva ElenaStoeva added Feature:Console Dev Tools Console Feature Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t// release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Oct 31, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

SoniaSanzV
SoniaSanzV reviewed Oct 31, 2025
View reviewed changes
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ElenaStoeva! I'm sorry I didn't catch that regression in my review.

ESQL suggestions look good to me in all cases, but I found something that I don't know if it's related to this PR.

For _query request I get suggestions for the body, but not for _query/async

Screenshot 2025-10-31 at 13 54 33 Screenshot 2025-10-31 at 13 53 25

Once I type "query" myself, I get the suggestions as expected:
Screenshot 2025-10-31 at 13 55 28

@ElenaStoeva
Copy link
Contributor Author

Thanks for reviewing @SoniaSanzV! Yeah, I noticed that too but that's not related to the ESQL suggestions - it happens because we don't have specs for the body param autocompletions for this endpoint, while the _query endpoint does - src/platform/plugins/shared/console/server/lib/spec_definitions/json/overrides/esql.query.json.

SoniaSanzV
SoniaSanzV approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@SoniaSanzV SoniaSanzV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for clarification @ElenaStoeva! Approving!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SoniaSanzV SoniaSanzV SoniaSanzV approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@ElenaStoeva ElenaStoeva

Labels

backport:skip This PR does not require backporting Feature:Console Dev Tools Console Feature release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more t//

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ElenaStoeva @elasticmachine @SoniaSanzV